feat(ui5-date-picker): component is now aligned with the specification #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Focus handling is aligned with the specification, when item is selected from a picker. - Selection is applied in compliance with the specification, when a picker is opened.
unazko
changed the title
unazko
changed the title
…into datepicker-enhance
|
There is still one issue left with the focus placement after a month or year is chosen. |
…into datepicker-enhance
…into datepicker-enhance
- Focus is now set inside the day picker component grid after, after a month or an year is chosen from the corresponding month picker or year picker component. - Focus in the day picker component can't be lost now as a result of pressing the forward or backward arrow buttons in the calendar component header section.
unazko
requested review from
ilhan007,
tsanislavgatev and
fifoosid
and removed request for
ilhan007,
tsanislavgatev and
fifoosid
…into datepicker-enhance
|
Looks good to me. But you have merge conflict @unazko |
…into datepicker-enhance
|
After a discussion with Vladislav I understood that the two additional tests need to be changed, in order to be stable and not introduce timing issues into the whole test set. |
…into datepicker-enhance
|
|
ilhan007
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus handling is aligned with the KBH specification:
is set to the last selected date or to the current date.
is set to the last selected date or to the current date.
if there are no selected dates.
if there are no selected dates.
Selection is applied in compliance with the UX specification, when a picker is opened:
selected dates.
Fixes #2151