Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-multi-combobox): n-more popover in readonly fixed #2394

Merged
merged 1 commit into from
Oct 27, 2020
Merged

fix(ui5-multi-combobox): n-more popover in readonly fixed #2394

merged 1 commit into from
Oct 27, 2020

Conversation

ivoplashkov
Copy link
Member

FIXES: #2369

@ivoplashkov ivoplashkov requested a review from ilhan007 October 23, 2020 10:29
fifoosid
fifoosid approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ilhan007 ilhan007 merged commit d045ba2 into SAP:master Oct 27, 2020
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
@ivoplashkov @ilhan007
fix(ui5-multi-combobox): n-more popover in readonly fixed (#2394)
05a4ffb 
FIXES: #2369
ilhan007 pushed a commit that referenced this pull request Nov 19, 2020
@ivoplashkov @ilhan007
fix(ui5-multi-combobox): n-more popover in readonly fixed (#2394)
b4227bc 
FIXES: #2369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid fifoosid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MultiComboBox] n-more label not working in read-only mode
3 participants
@ivoplashkov @ilhan007 @fifoosid