Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-busyindicator): fixed aria-labelledby value #3266

Merged
merged 2 commits into from
May 18, 2021
Merged

fix(ui5-busyindicator): fixed aria-labelledby value #3266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb64deb
fix(ui5-busyindicator): fixed aria-labelledby value
TeodorTaushanov May 18, 2021
ab51b4b
fix(ui5-busyindicator): fixed aria-labelledby value
TeodorTaushanov May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/BusyIndicator.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
aria-valuemin="0"
aria-valuemax="100"
aria-valuetext="Busy"
aria-labelledby="{{_id}}-label"
aria-labelledby="{{labelId}}"
>
<div class="ui5-busyindicator-circles-wrapper">
<div class="ui5-busyindicator-circle circle-animation-0"></div>
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/BusyIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ class BusyIndicator extends UI5Element {
return this.i18nBundle.getText(BUSY_INDICATOR_TITLE);
}

get labelId() {
return this.text ? this._id + "-label" : undefined;
TeodorTaushanov marked this conversation as resolved.
Show resolved Hide resolved
}

get classes() {
return {
root: {
Expand Down