Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-shellbar): fix search field width #3296

Merged
merged 11 commits into from
May 27, 2021
Merged

Conversation

PetyaMarkovaBogdanova
Copy link
Contributor

Aligning shellbar searchField with the UX specification to expand wider than half of the ShellBar
if no CoPilot icon is presented

Fixes #3240

@ilhan007 ilhan007 changed the title fix(ui5-shellbar):Fix shellbar searchbar width fix(ui5-shellbar): fix search field width May 20, 2021
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Someone from @SAP/ui5-webcomponents-topic-p should approve and me can merge it

@fifoosid fifoosid requested a review from a team May 25, 2021 07:34
@nnaydenow
Copy link
Contributor

Seems okey for me @fifoosid . You can submit it.

@fifoosid fifoosid merged commit 51fb1a3 into master May 27, 2021
@fifoosid fifoosid deleted the fix-shellbar-searchbar-width branch May 27, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShellBar: Inconsistent shrinking of searchfield
4 participants