fix(ui5-combobox): Autocomplete on Safari #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari losses input's text highlighting after invalidation of the ComboBox web component. In order to restore the highlighting we need to duplicate the highligh functionality onAfterRendering
d3xter666
requested review from
MapTo0,
hristop,
ndeshev,
niyap and
elenastoyanovaa
MapTo0
reviewed
Sep 27, 2021
MapTo0
reviewed
Sep 27, 2021
|
Unfortunately, it's not the perfect solution, but to be honest, I do not forsee any better implementation. Safari (the new IE :D ) is quite slow and re-rendering of a component is obvious for the end-user. |
Safari losses input's text highlighting after invalidation of the ComboBox web component. In order to restore the highlighting we need to duplicate the highligh functionality onAfterRendering
|
In chrome, when there is an autocompleted value for example if the user has entered a "Argen" and the value is autocompleted the word there is a following strange "tina" announcement of the autocompleted text. |
Safari losses input's text highlighting after invalidation of the ComboBox web component. In order to restore the highlighting we need to duplicate the highligh functionality onAfterRendering
MapTo0
approved these changes
Oct 19, 2021
Todor-ads
pushed a commit
that referenced
this pull request
Oct 28, 2021
* fix(ui5-combobox): Autocomplete on Safari Safari losses input's text highlighting after invalidation of the ComboBox web component. In order to restore the highlighting we need to duplicate the highligh functionality onAfterRendering * fix(ui5-combobox): Autocomplete on Safari Safari losses input's text highlighting after invalidation of the ComboBox web component. In order to restore the highlighting we need to duplicate the highligh functionality onAfterRendering * fix(ui5-combobox): Autocomplete on Safari Safari losses input's text highlighting after invalidation of the ComboBox web component. In order to restore the highlighting we need to duplicate the highligh functionality onAfterRendering
Todor-ads
added a commit
that referenced
this pull request
Oct 28, 2021
This reverts commit 55b7ed4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari losses input's text highlighting after invalidation of the ComboBox web component.
In order to restore the highlighting, we need to duplicate the highlight functionality onAfterRendering
Fixes: #3680