Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-flexible-column-layout): speech output on layout arrows #4034

Merged
merged 3 commits into from
Oct 6, 2021
Merged

fix(ui5-flexible-column-layout): speech output on layout arrows #4034

merged 3 commits into from
Oct 6, 2021

Conversation

nnaydenow
Copy link
Contributor

Fixes: #3699

@dobrinyonkov
Copy link
Contributor

There is a failing test for the aria-label attribute in /test/specs/FCL.spec.js.

fifoosid
fifoosid reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should merge the master branch for the build to pass

@ilhan007 ilhan007 merged commit 272e600 into SAP:master Oct 6, 2021
@ilhan007 ilhan007 mentioned this pull request Oct 6, 2021
Closed
ilhan007 pushed a commit that referenced this pull request Oct 6, 2021
@nnaydenow @ilhan007
fix(ui5-flexible-column-layout): speech output on layout arrows (#4034)
abfee41 
Fixes: #3699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid left review comments

@dobrinyonkov dobrinyonkov dobrinyonkov approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button: does not show the arial-label correctly to nvda screen reader when icon is full-screen
4 participants
@nnaydenow @dobrinyonkov @fifoosid @ilhan007