chore: make boolean props false by default #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested review from
pskelin and
MapTo0
and removed request for
pskelin
vladitasev
approved these changes
May 20, 2019
There was a problem hiding this comment.
We should delete the type === "boolean" check entirely, because it is old. We now only support the Boolean type. I see that in UI5Element and UI5ElementMedatada there are still checks for "boolean", "object" and the likes.
I would suggest that we merge this change and make an additional change to fix all type checks such as "boolean", "object", etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: ui5-checkbox has no default value for booleans #407