chore: rename theme-base to theming #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
approved these changes
Oct 20, 2021
Todor-ads
pushed a commit
that referenced
this pull request
Oct 28, 2021
Todor-ads
added a commit
that referenced
this pull request
Oct 28, 2021
This reverts commit c2992e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
theme-basepackage has been renamed tothemingto better indicate its purpose.Changes:
@ui5/webcomponents-theming: new package@ui5/webcomponents-theme-base: deprecated, removed from the yarn workspace, and will be deleted from the source code with the next public release.Note:
theme-baseis still the package used in1.0.0-rc.15, therefore it has not been removed from the mainREADME.mdfile. However, with the next release, it will be removed from there as well.BREAKING CHANGE: Third-party UI5 Web Components authors must change their dependencies and assets imports from "theme-base" to "theming" in their UI5 Web Components packages.
For example, if using
yarn:And change:
to