refactor(ui5-message-strip): rename tag name #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: MessageStrip component's tag name has been renamed from `ui5-messagestrip` to `ui5-message-strip`.
ilhan007
requested review from
MarcusNotheis,
fifoosid,
MapTo0,
elenastoyanovaa,
niyap and
nikolay-kolarov
d3xter666
approved these changes
Nov 5, 2021
elenastoyanovaa
approved these changes
Nov 5, 2021
ndeshev
pushed a commit
to ndeshev/ui5-webcomponents
that referenced
this pull request
Dec 13, 2021
Change tag name to ui5-message-strip to be consistent with components that may come in future, such as ui5-message-popover, ui5-message-dialog, ui5-message-*. Thanks to the altTag metadata entry, the old tag will still work, not to break consumers immediately, and later-on we can remove the altTag as well. BREAKING CHANGE: MessageStrip component's tag name has been renamed from ui5-messagestrip to ui5-message-strip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change tag name to
ui5-message-stripto be consistent with components that may come in future, such asui5-message-popover,ui5-message-dialog,ui5-message-*.Thanks to the
altTagmetadata entry, the old tag will still work, not to break consumers immediately, and later-on we can remove thealtTagas well.BREAKING CHANGE: MessageStrip component's tag name has been renamed from
ui5-messagestriptoui5-message-strip.