feat(ui5-link): provide accessible-name support #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
requested changes
Feb 8, 2022
packages/main/src/Link.js
Outdated
| * @type {string} | ||
| * @defaultvalue "" | ||
| * @public | ||
| * @since 1.0.0-rc.16 |
packages/main/src/Link.hbs
Outdated
| @@ -13,7 +13,7 @@ | |||
| @focusout={{_onfocusout}} | |||
| @click={{_onclick}} | |||
| @keydown={{_onkeydown}} | |||
| @keyup={{_onkeyup}}> | |||
| @@ -81,4 +81,10 @@ describe("General API", () => { | |||
| assert.strictEqual(await link.shadow$("a").getAttribute("aria-haspopup"), "Dialog", "Proper aria-haspopup attribute is set"); | |||
| }); | |||
|
|
|||
| it("setting accessible-name on the host is reflected on the link tag", async () => { | |||
There was a problem hiding this comment.
"applied on the host element is reflected on the anchor tag" sounds better.
unazko
requested changes
Feb 8, 2022
| * @since 1.0.0-rc.16 | ||
| */ | ||
| accessibleName: { | ||
| type: String, |
There was a problem hiding this comment.
There is default value in the documentation, but not in here.
ilhan007
reviewed
Feb 8, 2022
unazko
reviewed
Feb 8, 2022
ilhan007
reviewed
Feb 8, 2022
| @@ -81,4 +81,10 @@ describe("General API", () => { | |||
| assert.strictEqual(await link.shadow$("a").getAttribute("aria-haspopup"), "Dialog", "Proper aria-haspopup attribute is set"); | |||
| }); | |||
|
|
|||
| it("setting accessible-name applied on the host element is reflected on the anchor tag", async () => { | |||
| const link = await browser.$("#linkAccName").shadow$("а"); | |||
There was a problem hiding this comment.
Try the following:
const link = await browser.$("#linkAccName");
assert.strictEqual(await link.shadow$("a").getAttribute("aria-label"), "Application", "Attribute is reflected");
fifoosid
reviewed
Feb 9, 2022
unazko
previously approved these changes
Feb 9, 2022
unazko
reviewed
Feb 9, 2022
|
just one more remark, the starting verb f the commit msg should be with small letter - "provide". I will rename that. |
ilhan007
reviewed
Feb 9, 2022
|
And, as Filip and me commented |
ilhan007
previously approved these changes
Feb 9, 2022
ilhan007
changed the title
Fixed via the Github UI |
ilhan007
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new property "accessibleName"
Fixes: #4498