Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-calendar): render the correct length of day names #7866

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

tsanislavgatev
Copy link
Contributor

fixes: #7831

@ilhan007
Copy link
Member

ilhan007 commented Nov 16, 2023

Noticed that the issue authors need a downport to 1.14

Do the following: after merging the fix into the main branch:

  • Update your local "main" branch to get the fix

  • checkout latest 1.14.5 tag as a local branch with name release-1.14.6
    git checkout -b release-1.14.6 tags/v1.14.5

  • cherry-pick the fix into the newly created local branch (e.g. release-1.14.6)
    git cherry-pick commitSha

  • test that everything works as expected locally (1.14 is 5 months old, explore the code could be that the fix should be in different place, method , etc.)

  • push your local branch to the remote
    git push origin release-1.14.6

@tsanislavgatev tsanislavgatev merged commit 2a31e8d into main Nov 17, 2023
6 checks passed
@tsanislavgatev tsanislavgatev deleted the daypicker-fix branch November 17, 2023 13:54
@tsanislavgatev
Copy link
Contributor Author

Push to release-1.14.16 was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DayPicker] Day names are overlapped in Portuguese
3 participants