Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-popover): rename property placementType to placement #8596

Merged
merged 1 commit into from
Apr 1, 2024
Merged

refactor(ui5-popover): rename property placementType to placement #8596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fiori/src/NotificationOverflowActionsPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ui5-popover
class="ui5-notification-overflow-popover"
placement-type="Bottom"
placement="Bottom"
horizontal-align="End"
hide-arrow
>
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/src/ShellBarPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ui5-popover class="ui5-shellbar-menu-popover"
hide-arrow
placement-type="Bottom"
placement="Bottom"
@ui5-before-open={{_menuPopoverBeforeOpen}}
@ui5-after-close={{_menuPopoverAfterClose}}
>
Expand All @@ -12,7 +12,7 @@
</ui5-popover>

<ui5-popover class="ui5-shellbar-overflow-popover"
placement-type="Bottom"
placement="Bottom"
horizontal-align="{{popoverHorizontalAlign}}"
hide-arrow
@ui5-before-open={{_overflowPopoverBeforeOpen}}
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/WizardPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ui5-responsive-popover
horizontal-align="Center"
placement-type="Bottom"
placement="Bottom"
aria-label="{{actionSheetStepsText}}"
class="{{classes.popover}}"
@ui5-after-close={{_afterClosePopover}}
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/test/pages/NotificationListGroupItem.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@

<ui5-toast id="wcToastBS" duration="2000"></ui5-toast>

<ui5-popover id="notificationsPopover" class="notificationlistgroupitem2auto" placement-type="Bottom" horizontal-align="End">
<ui5-popover id="notificationsPopover" class="notificationlistgroupitem2auto" placement="Bottom" horizontal-align="End">
<ui5-list id="notificationListTop" header-text="Notifications titleText and content 'truncates'">
<ui5-li-notification-group
show-close
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/test/pages/NotificationListItem.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@

<ui5-toast id="wcToastBS" duration="2000"></ui5-toast>

<ui5-popover id="notificationsPopover" class="notificationlistitem2auto" placement-type="Bottom" horizontal-align="End">
<ui5-popover id="notificationsPopover" class="notificationlistitem2auto" placement="Bottom" horizontal-align="End">
<ui5-list id="notificationListTop" header-text="Notifications titleText and content 'truncates'">
<ui5-li-notification
show-close
Expand Down
6 changes: 3 additions & 3 deletions packages/fiori/test/pages/ShellBar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ <h3>ShellBar in Compact</h3>
</div>
</section>

<ui5-popover id="popover" placement-type="Bottom">
<ui5-popover id="popover" placement="Bottom">
<div class="popover-header">
<ui5-title class="shellbar2auto">John Doe</ui5-title>
</div>
Expand All @@ -164,7 +164,7 @@ <h3>ShellBar in Compact</h3>
</div>
</ui5-popover>

<ui5-popover id="app-list-popover" placement-type="Bottom">
<ui5-popover id="app-list-popover" placement="Bottom">
<ui5-list separators="None">
<ui5-li>Application 1</ui5-li>
<ui5-li>Application 2</ui5-li>
Expand All @@ -174,7 +174,7 @@ <h3>ShellBar in Compact</h3>
</ui5-list>
</ui5-popover>

<ui5-popover id="custom-item-popover" placement-type="Bottom">
<ui5-popover id="custom-item-popover" placement="Bottom">
<ui5-list separators="None">
<ui5-li id="custom-item-1" type="Active">Custom Popover Item 1</ui5-li>
<ui5-li type="Active">Custom Popover Item 2</ui5-li>
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/test/samples/NotificationListGroupItem.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ <h3>NotificationListGroupItem In ShellBar</h3>
>
</ui5-shellbar>

<ui5-popover id="notificationsPopover" style="max-width: 400px" placement-type="Bottom" horizontal-align="End">
<ui5-popover id="notificationsPopover" style="max-width: 400px" placement="Bottom" horizontal-align="End">
<ui5-list id="notificationListTop" header-text="Notifications grouped">
<ui5-li-notification-group
show-close
Expand Down Expand Up @@ -328,7 +328,7 @@ <h3>NotificationListGroupItem In ShellBar</h3>
<ui5-popover
id="notificationsPopover"
style="max-width: 400px"
placement-type="Bottom"
placement="Bottom"
horizontal-align="End"
>
<ui5-list header-text="Notifications">
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/test/samples/NotificationListItem.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ <h3>NotificationListItem In ShellBar</h3>
>
</ui5-shellbar>

<ui5-popover id="notificationsPopover" style="max-width: 400px" placement-type="Bottom" horizontal-align="End">
<ui5-popover id="notificationsPopover" style="max-width: 400px" placement="Bottom" horizontal-align="End">
<ui5-list id="notificationListTop" header-text="Notifications">
<ui5-li-notification
show-close
Expand Down Expand Up @@ -264,7 +264,7 @@ <h3>NotificationListItem In ShellBar</h3>
<ui5-popover
id="notificationsPopover"
style="max-width: 400px"
placement-type="Bottom"
placement="Bottom"
horizontal-align="Right"
>
<ui5-list header-text="Notifications">
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/test/samples/ProductSwitch.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ <h3>ProductSwitch within ShellBar</h3>
show-product-switch
show-co-pilot>
</ui5-shellbar>
<ui5-popover id="productswitch-popover" placement-type="Bottom">
<ui5-popover id="productswitch-popover" placement="Bottom">
<ui5-product-switch>
<ui5-product-switch-item title-text="Home" subtitle-text="Central Home" icon="home"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Analytics Cloud" subtitle-text="Analytics Cloud" icon="business-objects-experience"></ui5-product-switch-item>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h3>ProductSwitch within ShellBar</h3>
show-product-switch
show-co-pilot>
</ui5-shellbar>
<ui5-popover id="productswitch-popover" placement-type="Bottom">
<ui5-popover id="productswitch-popover" placement="Bottom">
<ui5-product-switch>
<ui5-product-switch-item title-text="Home" subtitle-text="Central Home" icon="home"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Analytics Cloud" subtitle-text="Analytics Cloud" icon="business-objects-experience"></ui5-product-switch-item>
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/test/samples/ShellBar.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ <h3>ShellBar</h3>
<ui5-li slot="menuItems">Application 5</ui5-li>
</ui5-shellbar>

<ui5-popover id="action-popover" placement-type="Bottom">
<ui5-popover id="action-popover" placement="Bottom">
<div class="action-popover-header">
<ui5-title style="padding: 0.25rem 1rem 0rem 1rem">An Kimura</ui5-title>
</div>
Expand Down Expand Up @@ -101,7 +101,7 @@ <h3>ShellBar</h3>

</ui5-shellbar>

<ui5-popover id="popover" placement-type="Bottom">
<ui5-popover id="popover" placement="Bottom">
<div class="popover-header">
<ui5-title style="padding: 0.25rem 1rem 0rem 1rem">An Kimura</ui5-title>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/BreadcrumbsPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
class="ui5-breadcrumbs-popover"
hide-arrow
content-only-on-desktop
placement-type="Bottom"
placement="Bottom"
horizontal-align="Start"
_hide-header
@keydown="{{_onkeydown}}">
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/ColorPalettePopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<ui5-responsive-popover
hide-arrow
content-only-on-desktop
placement-type="Bottom"
placement="Bottom"
?open="{{_open}}"
.opener="{{opener}}"
@ui5-after-close="{{onAfterClose}}"
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/ComboBoxPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<ui5-responsive-popover
class="{{classes.popover}}"
hide-arrow
placement-type="Bottom"
placement="Bottom"
horizontal-align="Start"
style="{{styles.suggestionsPopover}}"
@ui5-after-open={{_afterOpenPopover}}
Expand Down Expand Up @@ -96,7 +96,7 @@
hide-arrow
class="ui5-valuestatemessage-popover"
horizontal-align="{{_valueStatePopoverHorizontalAlign}}"
placement-type="Bottom"
placement="Bottom"
>
<div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
<ui5-icon class="ui5-input-value-state-message-icon" name="{{_valueStateMessageIcon}}"></ui5-icon>
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/DatePickerPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<ui5-responsive-popover
id="{{_id}}-responsive-popover"
allow-target-overlap
placement-type="Bottom"
placement="Bottom"
horizontal-align="Start"
hide-arrow
?_hide-header={{_shouldHideHeader}}
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/FileUploaderPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
prevent-focus-restore
hide-arrow
class="ui5-valuestatemessage-popover"
placement-type="Bottom"
placement="Bottom"
horizontal-align="Start"
>
<div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/InputPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="{{classes.popover}}"
hide-arrow
_disable-initial-focus
placement-type="Bottom"
placement="Bottom"
horizontal-align="Start"
style="{{styles.suggestionsPopover}}"
@ui5-after-open="{{_afterOpenPopover}}"
Expand Down Expand Up @@ -72,7 +72,7 @@
prevent-focus-restore
hide-arrow
class="ui5-valuestatemessage-popover"
placement-type="Bottom"
placement="Bottom"
horizontal-align="{{_valueStatePopoverHorizontalAlign}}"
>
<div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/Menu.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
id="{{_id}}-menu-rp"
class="ui5-menu-rp"
horizontal-align="Start"
placement-type={{placementType}}
placement={{placement}}
vertical-align={{verticalAlign}}
hide-arrow
allow-target-overlap
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/Menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import StandardListItem from "./StandardListItem.js";
import Icon from "./Icon.js";
import BusyIndicator from "./BusyIndicator.js";
import type MenuItem from "./MenuItem.js";
import PopoverPlacementType from "./types/PopoverPlacementType.js";
import PopoverPlacement from "./types/PopoverPlacement.js";
import type { ListItemClickEventDetail } from "./List.js";
import staticAreaMenuTemplate from "./generated/templates/MenuTemplate.lit.js";
import {
Expand Down Expand Up @@ -337,7 +337,7 @@ class Menu extends UI5Element {
return this.effectiveDir === "rtl";
}

get placementType(): `${PopoverPlacementType}` {
get placement(): `${PopoverPlacement}` {
const placement = this.isRtl ? "Start" : "End";
return this._isSubMenu ? placement : "Bottom";
}
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/MultiComboBoxPopover.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<ui5-responsive-popover
placement-type="Bottom"
placement="Bottom"
horizontal-align="Start"
class="{{classes.popover}}"
hide-arrow
Expand Down Expand Up @@ -106,7 +106,7 @@
prevent-focus-restore
hide-arrow
class="ui5-valuestatemessage-popover"
placement-type="Bottom"
placement="Bottom"
horizontal-align="{{_valueStatePopoverHorizontalAlign}}"
>
<div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
Expand Down
Loading