Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-list): renamed busy, busyDelay to loading, loadingDelay #8686

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

plamenivanov91
Copy link
Contributor

@plamenivanov91 plamenivanov91 commented Apr 8, 2024

Renames the busy, busyDelay property of the ui5-list to loading and loadingDelay.

BREAKING CHANGE: The busy property of the ui5-list is renamed.
If you have previously used the busy, busyDelay properties:

<ui5-list busy busy-delay="500"></ui5-list>

now you must use loading and loadingDelay properties:

<ui5-list loading loading-delay="500"></ui5-list>

Related: #8461 #7887

@ilhan007
Copy link
Member

ilhan007 commented Apr 8, 2024

There is some usage in the new samples that needs to be adjusted as well:

Screenshot 2024-04-08 at 16 23 26

@plamenivanov91
Copy link
Contributor Author

There is some usage in the new samples that needs to be adjusted as well:

Screenshot 2024-04-08 at 16 23 26

Thanks, I completely forgot the new samples. May be it's a good idea to include them in some of the existing builds or create a new one.

@ilhan007
Copy link
Member

ilhan007 commented Apr 8, 2024

There is some usage in the new samples that needs to be adjusted as well:
Screenshot 2024-04-08 at 16 23 26

Thanks, I completely forgot the new samples. May be it's a good idea to include them in some of the existing builds or create a new one.

Unfortunately sample.html is html file even non-existing attributes won't throw errors, for the js files, maybe we can rework them to .ts in future.

@ilhan007 ilhan007 changed the title refactor(ui5-list): renamed busy property refactor(ui5-list): renamed busy, busyDelay to loading, loadingDelay Apr 8, 2024
@ilhan007 ilhan007 merged commit 38e4df4 into SAP:main Apr 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants