fix(ui5-shellbar): aligned specs #8694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetyaMarkovaBogdanova
force-pushed
the
align-shellbar-specs
branch
from
264f4d4 to
7d3ac15
Compare
PetyaMarkovaBogdanova
force-pushed
the
align-shellbar-specs
branch
from
7d3ac15 to
7d2b4bb
Compare
| @@ -52,14 +52,23 @@ | |||
| word-spacing: inherit; | |||
| } | |||
|
|
|||
| .ui5-shellbar-button[icon-only] { | |||
| color: var(--sapShell_InteractiveTextColor); | |||
There was a problem hiding this comment.
resulting in the same color as the current version (var(--sapShell_TextColor);)
| } | ||
|
|
||
| .ui5-shellbar-button[icon-only]:hover:not(:active) { | ||
| color: var(--sapShell_InteractiveTextColor); |
| .ui5-shellbar-menu-button.ui5-shellbar-menu-button--interactive:hover, | ||
| .ui5-shellbar-button:hover, | ||
| .ui5-shellbar-image-button:hover { | ||
| ::slotted([ui5-button][slot="startButton"]:hover:not([active])), |
There was a problem hiding this comment.
In the rest of the file we have styles which are with stronger rules for the active state. Rendering those 4 new additions irrelevant.
Are you sure they need to be added and if there is any visual difference with or without them?
plamenivanov91
approved these changes
Apr 11, 2024
PetyaMarkovaBogdanova
added a commit
that referenced
this pull request
Apr 16, 2024
This reverts commit c5ec720.
PetyaMarkovaBogdanova
added a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual alignments done to meet the last Visual specification updates