-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-badge): new property added #8714
Conversation
We have to think about the values Standard, Large look a bit odd, also we tried to align the Avatar and the BusyIndicator like this. I will also take this with me, but please don't merge before we agree on the values. enum AvatarSize {
XS = "XS",
S = "S",
M = "M",
L = "L",
XL = "XL",
}```
and
```ts
enum BusyIndicatorSize {
S = "S",
M = "M",
L = "L",
}``` |
this is only a working version we will have a discussion to decide on property values. |
packages/main/src/types/BadgeSize.ts
Outdated
@@ -0,0 +1,19 @@ | |||
/** | |||
* Defines badge size types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"size types" is not the best wording. Maybe:
Defines badge size options.
or
Predefined sizes for the badge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Predefined sizes for the badge". sounds good to me
packages/main/src/types/BadgeSize.ts
Outdated
*/ | ||
enum BadgeSize { | ||
/** | ||
* Standard size of the badge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls. double check. "Standard" is OK, but implies that it should always be the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"S" is for small, this is old wording.
Form UA perspective I approve the PR... |
No description provided.