Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-split-button): restrict height manipulation from outside wrapper #8780

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Apr 17, 2024

Previously when our ui5-split-button component was wrapped in a container with defined height, f.e:

<div style="border: 1px solid red; height: 80px">
	<ui5-split-button style="width: 100%;" icon="picture">Random Text</ui5-split-button>
</div>

The button was filling the whole space in the container, which wasn't the desired behaviour:

image

Now the ui5-split-button's height is not based on outside wrappers.

Fixes: #8705

@unazko unazko self-requested a review April 17, 2024 11:50
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as stated.

@hinzzx hinzzx marked this pull request as ready for review April 17, 2024 13:57
@hinzzx hinzzx merged commit 691c68e into main Apr 22, 2024
9 checks passed
@hinzzx hinzzx deleted the split-btn-height-fix branch April 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-split-button]: component breaks if container has fixed height
3 participants