feat(ui5-input): allow custom icon styling #8881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
requested review from
ilhan007,
nnaydenow,
pskelin,
vladitasev,
MapTo0 and
ivoplashkov
vladitasev
reviewed
May 2, 2024
packages/website/docs/_samples/main/Input/CustomIcon/CustomIcon.md
Outdated
Show resolved
Hide resolved
ilhan007
reviewed
May 14, 2024
packages/website/docs/_samples/main/Input/CustomIcon/CustomIcon.md
Outdated
Show resolved
Hide resolved
nnaydenow
reviewed
May 14, 2024
nnaydenow
approved these changes
May 14, 2024
ilhan007
requested changes
May 14, 2024
| @@ -16,26 +9,26 @@ | |||
| border-radius: var(--_ui5_input_icon_border_radius); | |||
| } | |||
|
|
|||
| [input-icon][pressed] { | |||
| .inputIcon [pressed] { | |||
There was a problem hiding this comment.
.inputIcon [pressed]should be without space, otherwise it won't match the icon as expected
.inputIcon[pressed]
ilhan007
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusable component styles
Introduce reusable css styles for input icons in order to be used by applications using icons in the input-type of components as a slot.
input-iconhtml attribute to reuse the input icon styling with the newinputIconclass.The approach is from #8182 .
FIXES: #6132