-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-combobox): introduce nested grouping of items #8926
Conversation
fix filtering and selection
fix item selection bugs implement partial navigation focus handling
improve focus handling
add accessibility roles and tests
fix mobile tests
fix item filtration on mobile
minor refactoring and fixes
refactor group items checks
fix condition bug
revert selectioon-change parameter type
fix item types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproducible on main branch:
- Navigate through the items using arrow down and then navigate through the value with arrow left/right and then navigate the items again => value gets partially selected instead of completely selected.
- When you have items with grouping and you select an item with enter, then open picker and press Enter on the group, change event is fired (because the value get cleared, but not sure if this should happen as this cannot be achieved with mouse as the group item is not clickable).
- Click on items with grouping sample and press Shift + tab, sample remains visually focused.
Bugs introduced with the change:
Items with grouping sample:
- focus input without opening the picker and navigate through the values using ArrowDown => only items from the first group are being selected.
- same interaction as above but instead of ArrowDown, navigate with Fn + ArrowDown until you hit “Madagascar”, upon ArrowUp => exception is thrown.
- Open picker, navigate to any item and press Alt + Down => value gets cleared
- Open picker, navigate down the items with ArrowDown => Upon reaching Australia picker gets scrolled to the bottom for no reason.
- Open picker, press End button => picker is not scrolled to the last item.
fix code review bugs
remove isGroupItem check from ComboBoxItem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some tests for the fixed issues?
|
add more tests for navigation and selection behavior
Replace flat item structure with nested grouping.
Removes the
ui5-cb-group-item
component.BREAKING CHANGE: The
ui5-cb-group-item
component is removed. Groups can now be created with theui5-cb-item-group
. Instead of using the oldui5-cb-group-item
as separator in a flat structure:The API supports nesting of
ui5-cb-item
components inside anui5-cb-item-group
: