Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-menu): include icon #9413

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(ui5-menu): include icon #9413

merged 2 commits into from
Jul 8, 2024

Conversation

tsanislavgatev
Copy link
Contributor

Add icon import, as the icon is currently not showing.

nnaydenow
nnaydenow requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the icon should be imported inside menu items, not in the menu

@tsanislavgatev tsanislavgatev requested a review from nnaydenow July 8, 2024 12:35
@tsanislavgatev tsanislavgatev marked this pull request as ready for review July 8, 2024 14:19
@tsanislavgatev tsanislavgatev merged commit d5508a7 into main Jul 8, 2024
10 checks passed
@tsanislavgatev tsanislavgatev deleted the menu-icon-dependency branch July 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHristov-sap NHristov-sap NHristov-sap approved these changes

@nnaydenow nnaydenow nnaydenow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsanislavgatev @nnaydenow @NHristov-sap