fix(ui5-multi-combobox, ui5-combobox, ui5-input): improve popup announcement #9514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
requested review from
ivoplashkov,
MapTo0,
nikoletavnv and
ndeshev
ivoplashkov
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a header, nor a label is provided to an element with role dialog JAWS reads out the <title> element of the html document as a dialog header, once a dialog is opened/focused. In order to overcome this side effect and future announcemnt deviations the suggestion popover elements are now labelled following the existing pattern from UI5.
FIXES: #9116