New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-card): add loadingIndicator slot #9532

Closed

dimovpetar wants to merge 1 commit into main from poc_loading_indicator_slot

+50 −3

Contributor

dimovpetar commented Jul 22, 2024

Related to: #9437


          feat: add loadingIndicator slot to Card component

79a3d8d

dimovpetar marked this pull request as draft

July 22, 2024 09:15

dimovpetar changed the title ~~feat: add loadingIndicator slot to Card component~~ feat(ui5-card): add loadingIndicator slot

Contributor Author

dimovpetar commented Jul 26, 2024

slot pros:

all properties of ui5-busy-indicator will be available to the app developers

slot cons:

card must handle keyboard interactions on its own

As other components already use loading property, we decided to also go for property on the card. Continued with #9558

dimovpetar closed this

dimovpetar deleted the poc_loading_indicator_slot branch

July 26, 2024 10:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet