Skip to content

Commit

Permalink
add notes about non matching songs
Browse files Browse the repository at this point in the history
  • Loading branch information
freshollie committed May 3, 2022
1 parent 8caa8d4 commit 791899f
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 13 deletions.
29 changes: 17 additions & 12 deletions scripts/match_next_midi.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
all_time_signatures.append(ts)

for next_song in to_match:
if next_song != "song0044":
continue

if next_song in skipped:
print(f"skipping {next_song}")
continue
Expand All @@ -47,19 +50,21 @@
print('Cleaning build')
os.system('make tidy >/dev/null 2>&1')

# for absolute_ticks in range(0, 25):
# print(f'Trying absolute ticks {absolute_ticks}')
# os.system(f'python3 scripts/edit_time_signature.py {next_song} 4 4 {absolute_ticks}')
# # if absolute_ticks:
# # print(f'applying time signature {ts[0]}/{ts[1]}')
# # os.system(f'python3 scripts/edit_time_signature.py {next_song} {ts[0]} {ts[1]}')
success = False
for ts in all_time_signatures:
if ts:
print(f'applying time signature {ts[0]}/{ts[1]}')
os.system(f'python3 scripts/edit_time_signature.py {next_song} {ts[0]} {ts[1]}')

print('Verifying build')
error = os.system("make >/dev/null 2>&1")
if not error:
print('success!')
os.system('git add -A')
else:
print('Verifying build')
error = os.system("make >/dev/null 2>&1")
if not error:
print('success!')
os.system('git add -A')
success = True
break

if not success:
print('fail, reverting')
os.system('git checkout -- sound ldscript.txt')
os.system('git clean -f >/dev/null 2>&1')
6 changes: 5 additions & 1 deletion sound/songs/midi/non_matching/NOTES.md
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
* GOTO in middle of track doesn't handle the ending for some reason
* song0020: line 5627 (of compiled) doesn't reuse the previous pattern even though it's identical. Need to understand how mid2agb detects these
* song0046: line 429 (of compiled) has a weird time signature change
* song0291: needs something to change at tick 24?
* song0044: some time signature shift and maybe multiple time signatures
* song0042: time should start at 96, first track fits 4/6, other don't after some point
Binary file modified sound/songs/midi/non_matching/song0044.mid
Binary file not shown.

0 comments on commit 791899f

Please sign in to comment.