Some more documentation and cleanup #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshollie
reviewed
Dec 31, 2024
Comment on lines
+1734
to
+1735
| #include "../chao_garden/include/language.h" | ||
| #include "../chao_garden/include/program_params.h" |
There was a problem hiding this comment.
Not sure I like the relative includes. We can add chao_garden include to the -I path and then name the headers something with chao_garden in the name, or we can have a folder called chao_garden in there?
There was a problem hiding this comment.
Also, why are these not at the top?
There was a problem hiding this comment.
I'm also for just not passing headers to SA2 since they likely just hard coded these anyway :/
freshollie
reviewed
Dec 31, 2024
| // TODO: what is going on here, doesn't work as a struct | ||
| // TODO: what's unk374 | ||
| TinyChaoGardenConfig[0] = unk374; | ||
| #if (GAME == GAME_SA1) |
There was a problem hiding this comment.
Tbh, are we really gonna share these files between sa1 and sa2? I would imagine the rest of the file is completely differnent.
freshollie
reviewed
Jan 3, 2025
| /* 0x06 */ u16 unk6; | ||
| /* 0x08 */ Sprite s; | ||
| } BrakeDustEffect; | ||
|
|
||
| typedef struct { | ||
| s8 unk0; | ||
| u8 filler1[3]; |
There was a problem hiding this comment.
You can probably remove this now :)
freshollie
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.