(WIP) First, bad, groundwork implementation of OpenGL backend #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshollie
reviewed
Jan 11, 2025
| @@ -88,6 +88,11 @@ NONMATCH("asm/non_matching/engine/sub_8002B20.inc", bool32 sub_8002B20(void)) | |||
| s32 j; | |||
| u16 k; | |||
|
|
|||
| #if (RENDERER == RENDERER_OPENGL) | |||
There was a problem hiding this comment.
Might as well be consistent and do if (RENDERER == RENDERER_SOFTWARE) around the whole thing?
There was a problem hiding this comment.
For such a big function? I'd rather keep it with a short #ifdef.
freshollie
reviewed
Jan 11, 2025
src/core.c
Outdated
| @@ -720,7 +720,9 @@ static bool32 ProcessVramGraphicsCopyQueue(void) | |||
| if ((graphics->src != 0) && (graphics->dest != 0)) | |||
| #endif | |||
| { | |||
| #if (RENDERER != RENDERER_OPENGL) | |||
There was a problem hiding this comment.
Renderer == software for these too?
There was a problem hiding this comment.
Here I'd like to keep everything except the memcpy intact, because I don't yet know if it breaks something if the size isn't reduced correctly. As well as INC_GRAPHICS_QUEUE_CURSOR() not being called otherwise.
There was a problem hiding this comment.
Yeah that's fine, I guess I just meant you could use RENDER == software instead of RENDERER != OPEN_GL?
freshollie
reviewed
Jan 11, 2025
freshollie
reviewed
Jan 11, 2025
freshollie
reviewed
Jan 11, 2025
freshollie
reviewed
Jan 11, 2025
freshollie
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.