Skip to content

Commit

Permalink
FIX: use inceptionv4 from timm (#69)
Browse files Browse the repository at this point in the history
* use inceptionv4 from timm

This changes the model name from inceptionv4 to inception_v4 and allows
us to remove the inceptionv4 implementation from the codebase.

* use inception_v4nobn with help of timm

Use the timm implementation but remove batchnorm (and add bias to the
conv layer before batchnorm).

This changes the name from inceptionv4nobn to inception_v4nobn.

* rm unused default_cfgs

* ignore timm types
  • Loading branch information
kaczmarj authored Jan 15, 2023
1 parent 1cc6f6a commit 1683bba
Show file tree
Hide file tree
Showing 7 changed files with 127 additions and 387 deletions.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ ignore_missing_imports = True
ignore_missing_imports = True
[mypy-pandas]
ignore_missing_imports = True
[mypy-timm]
[mypy-timm.*]
ignore_missing_imports = True
[mypy-scipy.stats]
ignore_missing_imports = True
Expand Down
6 changes: 3 additions & 3 deletions tests/test_all.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ def test_cli_run_args(tmp_path: Path):
350,
144,
),
# Inceptionv4 TCGA-BRCA-v1
# Inception_v4 TCGA-BRCA-v1
(
"inceptionv4",
"inception_v4",
"TCGA-BRCA-v1",
["notumor", "tumor"],
[0.9564113020896912, 0.043588679283857346],
Expand All @@ -227,7 +227,7 @@ def test_cli_run_args(tmp_path: Path):
),
# Inceptionv4nobn TCGA-TILs-v1
(
"inceptionv4nobn",
"inception_v4nobn",
"TCGA-TILs-v1",
["notils", "tils"],
[1.0, 3.427359524660334e-12],
Expand Down
306 changes: 0 additions & 306 deletions wsinfer/_modellib/inceptionv4.py

This file was deleted.

Loading

0 comments on commit 1683bba

Please sign in to comment.