Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve playback usability #354

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Conversation

cravend
Copy link
Collaborator

@cravend cravend commented Apr 16, 2023

  • refactor: move player into subdirectory
  • feat: create player context
  • feat: pass current device id to play button
  • fix: fix track playback context
  • feat: register two player instances to avoid autoplay issues

Copy link
Contributor

@jccrews jccrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking play other part of screen refreshes

Screen.Recording.2023-04-17.at.5.11.06.PM.mov

Copy link
Contributor

@jccrews jccrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reload is fixed but now table overflows and sidebar does overflows off side of screen.

Screen.Recording.2023-04-17.at.5.43.58.PM.mov

@cravend cravend merged commit e831441 into main Apr 18, 2023
@cravend cravend deleted the 343-playback-feature-does-not-work branch April 18, 2023 03:59
@cravend cravend mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants