Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region borders misplot for concave regions #197

Closed
pabloitu opened this issue Sep 19, 2022 · 2 comments · Fixed by #199
Closed

region borders misplot for concave regions #197

pabloitu opened this issue Sep 19, 2022 · 2 comments · Fixed by #199

Comments

@pabloitu
Copy link
Collaborator

The boundaries of a region fails to plot correctly when the region is concave in the x axis (a horizontal line touches the region twice).
See northern edge of NZ, or two small cells in the eastern edge:

will try a quick solution using shapely (merge cell polys and then get boundary)

@wsavran
Copy link
Collaborator

wsavran commented Sep 19, 2022

Good catch! Do you have any idea why this is happening or better yet, any ideas for a fix?

@pabloitu
Copy link
Collaborator Author

I would try to use shapely (pygeos) to find a quick boundary extraction instead of coding it myself. Will take a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants