-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: region border plot #199
Conversation
…ets the boundary of the total region. Bypasses floating point issues by rounding down to 2 decimals
docs are failing the build with this new function. i also think we need to add shapely to the requirements and the build. it's implicitly provided through cartopy but i think we want to explicitly put it with our distribution. |
actually good that it failed the docs. For some reason it's failing in CA, which i didnt tested. Need to take a look further. Will put shapely in the reqs also. |
fix: tight_bbox has option for precision. It is not necessary for lat_lon, but explicited the argument, in case cartesian coordinates were implemented. build: added shapely as requirement
build fail was because of plot_gridded_forecast tutorial, which loaded helmstetter from ascii. In this func, parsing the file made self-intersecting cell polygons. Fixed #200 and now boundaries can be plotted for NZ, Italy and california without problems. |
Codecov ReportBase: 55.73% // Head: 55.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 55.73% 55.73% -0.01%
==========================================
Files 20 20
Lines 3572 3594 +22
Branches 569 580 +11
==========================================
+ Hits 1991 2003 +12
- Misses 1460 1466 +6
- Partials 121 125 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
reviewed the pull request, everything looks good except for 2 pieces. first we need to add shapely to setup.py and the requirements.yml and i'll merge it. |
done |
fixes #197. Now uses shapely to merge all cell polygons into one, and extract the borders. Floating point issues with coincident cell edges are sorted out by rounding up to 2 decimals.
pyCSEP Pull Request Checklist
Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.
Fixes issue #197 #200.
Type of change:
Please delete options that are not relevant.
Checklist: