Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in MaCOS and deactivate travis #205

Closed
2 tasks done
felipeZ opened this issue Jun 18, 2020 · 4 comments · Fixed by #206
Closed
2 tasks done

Run tests in MaCOS and deactivate travis #205

felipeZ opened this issue Jun 18, 2020 · 4 comments · Fixed by #206
Assignees
@felipeZ
Labels
Tests Updated the unit-tests

Comments

@felipeZ
Copy link
Contributor

felipeZ commented Jun 18, 2020 •
edited
Loading

TODO:

  • Run Tests on MacOS
  • Deactivate Travis
@felipeZ felipeZ self-assigned this Jun 18, 2020
@BvB93
Copy link
Collaborator

BvB93 commented Jun 18, 2020

By the way, what was the reason for dropping python 3.6 support again?

@BvB93 BvB93 added the Tests Updated the unit-tests label Jun 18, 2020
@felipeZ
Copy link
Contributor Author

felipeZ commented Jun 18, 2020 •
edited
Loading

By the way, what was the reason for dropping python 3.6 support again?

I have a terrible memory, I am not sure if there was an issue at all. We can add it and see if it works :)

@BvB93
Copy link
Collaborator

BvB93 commented Jun 18, 2020

Found it, it seems to have been changed because of a noodles version bump (#130).
Something related to noodles' bump to python >= 3.7 because of NLeSC/noodles#80.

@BvB93
Copy link
Collaborator

BvB93 commented Jun 18, 2020 •
edited
Loading

Eh, let's just give python 3.6 a shot and see if it fails or not.

@felipeZ felipeZ mentioned this issue Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipeZ felipeZ

Labels
Tests Updated the unit-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deactivate Travis and run MacOs on GH actions SCM-NV/qmflows
2 participants
@felipeZ @BvB93