Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Travis and run MacOs on GH actions #206

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Deactivate Travis and run MacOs on GH actions #206

merged 4 commits into from
Jun 18, 2020

Conversation

felipeZ
Copy link
Contributor

@felipeZ felipeZ commented Jun 18, 2020

fix #205

@felipeZ felipeZ requested a review from BvB93 June 18, 2020 11:22
@BvB93 BvB93 added the Tests Updated the unit-tests label Jun 18, 2020
Copy link
Collaborator

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the minimum python version it the pypi classifiers:

'Programming Language :: Python :: 3.7',
.

@BvB93
Copy link
Collaborator

BvB93 commented Jun 18, 2020

The rest is looking good btw.

@BvB93
Copy link
Collaborator

BvB93 commented Jun 18, 2020

Don't forget to change the minimum python version it the pypi classifiers:

Oh hang on, that's not the minimum version but all supported version.
Should be

...
'Programming Language :: Python :: 3.6', 
'Programming Language :: Python :: 3.7', 
'Programming Language :: Python :: 3.8', 
...

@BvB93
Copy link
Collaborator

BvB93 commented Jun 18, 2020

Btw, should we set the python_requires=">=3.6" option in setup.py (ref)?
This is actually a proper minimum version and will prevent installation on python versions older than 3.6.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #206 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   81.77%   81.94%   +0.16%     
==========================================
  Files          39       39              
  Lines        1855     1855              
  Branches      235      235              
==========================================
+ Hits         1517     1520       +3     
+ Misses        267      265       -2     
+ Partials       71       70       -1     
Impacted Files Coverage Δ
src/qmflows/backports.py 86.66% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0269cc9...2a7f84d. Read the comment docs.

@felipeZ felipeZ merged commit 81a80ba into master Jun 18, 2020
@felipeZ felipeZ deleted the osx branch June 18, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Updated the unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests in MaCOS and deactivate travis
3 participants