adios_comm: close the engine in dtor #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADIOS2 Engine objects need to have
Close()
called by the user (see my mistake here ornladios/ADIOS2#3269 (comment)).This PR adds a destructor for the
AdiosComm
class to close the engine. Following the rule of 5, I explicitly marked the copy/move assignment/constructors asdelete
as I currently only want users to callCreateAdiosComm(...)
and not manipulate individual comm objects.@jacobmerson Do you see a problem here? Is there a reason to allow
AdiosComm
object copy/move?