Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.22.1 #141

Merged
merged 11 commits into from
Dec 29, 2018
Merged

2.22.1 #141

merged 11 commits into from
Dec 29, 2018

Conversation

dwrusse
Copy link
Contributor

@dwrusse dwrusse commented Dec 28, 2018

No description provided.

@SCRT-HQ SCRT-HQ deleted a comment Dec 28, 2018
@SCRT-HQ SCRT-HQ deleted a comment Dec 28, 2018
@dwrusse
Copy link
Contributor Author

dwrusse commented Dec 28, 2018

Realized that my Get-GSCalendarList function was basically a duplicate of Get-GSCalendarSubscription. So I merged the two, adding some minor functionality to the Get-GSCalendarSubscription function.

Copy link
Member

@scrthq scrthq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this over, @dwrusse!! I added some review notes on things that need to get updated if you have some time! Otherwise, I can pull it and make the updates to your fork directly before merging. Let me know what works best for you!

PSGSuite/Public/Calendar/Get-GSCalendarSubscription.ps1 Outdated Show resolved Hide resolved
PSGSuite/Public/Calendar/Get-GSCalendarSubscription.ps1 Outdated Show resolved Hide resolved
PSGSuite/Public/Drive/Remove-GSDriveFile.ps1 Outdated Show resolved Hide resolved
@scrthq scrthq self-assigned this Dec 28, 2018
@ghost ghost added the work in progress label Dec 29, 2018
Copy link
Member

@scrthq scrthq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the updates needed and pushed to your fork's master! Getting this merged asap.

@scrthq scrthq merged commit 5ae82c6 into SCRT-HQ:master Dec 29, 2018
@ghost ghost removed the work in progress label Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants