Skip to content

Commit

Permalink
chore: bump eslint-plugin-svelte version to fix linting bug
Browse files Browse the repository at this point in the history
In version 2.46.1, which we previously used, eslint couldn't handle svelte each blocks without 'as'.
We use on of these blocks on the project members settings page (src/routes/project/[projectId]/settings/members/+page.svelte):
```svelte
{#each { length: numberOfSkeletons }, i}
    <ProjectMemberListEntrySkeleton />
    {#if i < numberOfSkeletons - 1}
        <Separator />
    {/if}
{/each}
```
This was reported in sveltejs/eslint-plugin-svelte#953 and fixed in version 3.0.0-next.5.
Now eslint works again with our codebase.
  • Loading branch information
Slartibartfass2 committed Feb 18, 2025
1 parent f4a1b68 commit 13f60ca
Show file tree
Hide file tree
Showing 3 changed files with 61 additions and 89 deletions.
14 changes: 12 additions & 2 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import prettier from "eslint-config-prettier";
import js from "@eslint/js";
import svelte from "eslint-plugin-svelte";
import svelteParser from "svelte-eslint-parser";
import globals from "globals";
import ts from "typescript-eslint";

Expand All @@ -19,9 +20,18 @@ export default ts.config(
},
},
{
files: ["**/*.svelte"],

files: ["**/*.svelte", "*.svelte"],
languageOptions: {
parser: svelteParser,
parserOptions: {
parser: ts.parser,
},
},
},
{
files: ["**/*.svelte.ts", "*.svelte.ts"],
languageOptions: {
parser: svelteParser,
parserOptions: {
parser: ts.parser,
},
Expand Down
134 changes: 48 additions & 86 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"clsx": "^2.1.1",
"eslint": "^9.20.1",
"eslint-config-prettier": "^10.0.1",
"eslint-plugin-svelte": "^2.46.1",
"eslint-plugin-svelte": "^3.0.0-next.18",
"fzf": "^0.5.2",
"globals": "^15.13.0",
"jsdom": "^26.0.0",
Expand Down

0 comments on commit 13f60ca

Please sign in to comment.