Galen & Wendy's html5 as a platform assignment #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atform Conflicts: .DS_Store Audio/.DS_Store
Merge branch 'master' of https://github.com/gkbroderick/html5-as-a-platform
Please enter the commit message for your changes. Lines starting
…atform Trying to solve DS STORE HELL
| <source src="Audio Converts/FillOutSomeForms.ogg" type="audio/mp3"> | ||
| <source src="Audio Converts/FillOutSomeForms.wav" type="audio/mp3"> | ||
| </audio> | ||
| <br> |
There was a problem hiding this comment.
br tags have no semantic meaning, do not use.
| <button onclick="frameChange(-2)" type="button"> Rewind </button> | ||
| <button onclick="restart()" type="button">Restart</button><br> | ||
| <button onclick="pauseplay()" type="button">PausePlay</button> | ||
|
|
There was a problem hiding this comment.
Remove empty line.
|
Thanks for the comments. I unfortunately buried them a little when I made a central "Galen-Wendy" folder for our project. We got together today and cleaned up all the areas you pointed out. We also deleted any unnecessary empty lines of code we found elsewhere. We replaced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.