validate-appconfig.py: Add further validations. #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebenito
force-pushed
the
validate-appconfig-more
branch
2 times, most recently
from
065595f to
8916695
Compare
Signed-off-by: Chris PeBenito <[email protected]>
Results in ouput such as: Validating refpolicy appconfig. tmp/appconfig/default_contexts: Warning: Invalid source domain: staff_r:staff_su_t:s0. tmp/appconfig/default_contexts: Warning: Invalid source domain: user_r:user_su_t:s0. tmp/appconfig/default_contexts: Warning: Invalid source domain: user_r:user_sudo_t:s0. tmp/appconfig/user_u_default_contexts: Warning: No valid target domains for system_r:crond_t:s0 tmp/appconfig/user_u_default_contexts: Warning: Invalid source domain: user_r:user_su_t:s0. tmp/appconfig/user_u_default_contexts: Warning: Invalid source domain: user_r:user_sudo_t:s0. tmp/appconfig/root_default_contexts: Warning: No valid target domains for system_r:crond_t:s0 tmp/appconfig/root_default_contexts: Warning: Invalid source domain: staff_r:staff_su_t:s0. tmp/appconfig/root_default_contexts: Warning: Invalid source domain: user_r:user_su_t:s0. tmp/appconfig/staff_u_default_contexts: Warning: No valid target domains for system_r:crond_t:s0 tmp/appconfig/staff_u_default_contexts: Warning: Invalid source domain: staff_r:staff_su_t:s0. tmp/appconfig/xguest_u_default_contexts: Warning: Invalid user xguest_u: Skipping validation. tmp/appconfig/unconfined_u_default_contexts: Warning: No valid target domains for system_r:init_t:s0 tmp/appconfig/unconfined_u_default_contexts: Warning: Source domain system_r:initrc_t:s0 not in default_contexts. tmp/appconfig/unconfined_u_default_contexts: Warning: No valid target domains for system_r:remote_login_t:s0 tmp/appconfig/unconfined_u_default_contexts: Warning: Source domain system_r:rshd_t:s0 not in default_contexts. tmp/appconfig/unconfined_u_default_contexts: Warning: Invalid source domain: system_r:sysadm_su_t:s0. tmp/appconfig/unconfined_u_default_contexts: Warning: Source domain system_r:unconfined_t:s0 not in default_contexts. tmp/appconfig/xdm_default_contexts: Warning: No valid target domains for system_r:xdm_t:s0 tmp/appconfig/xdm_default_contexts: Error: No valid lines. tmp/appconfig/guest_u_default_contexts: Warning: Invalid user guest_u: Skipping validation. make: *** [Rules.monolithic:250: validate] Error 1 Signed-off-by: Chris PeBenito <[email protected]>
Signed-off-by: Chris PeBenito <[email protected]>
Add PYTHONPATH to the environment. The PYTHONPATH manipulation done by the Makefiles causes the pip install location to be lost from the path, and the setools module won't load. Signed-off-by: Chris PeBenito <[email protected]>
Signed-off-by: Chris PeBenito <[email protected]>
Remove unnecessary role definition in kernel.te. Signed-off-by: Chris PeBenito <[email protected]>
Signed-off-by: Chris PeBenito <[email protected]>
pebenito
force-pushed
the
validate-appconfig-more
branch
2 times, most recently
from
df53554 to
4bd1158
Compare
|
@perfinion or @0xC0ncord can you try this out? I imagine binary distros wouldn't have a problem with (optionally) having setools during build, but as Gentoo is source... |
Signed-off-by: Chris PeBenito <[email protected]>
pebenito
force-pushed
the
validate-appconfig-more
branch
from
a42236f to
800b4a2
Compare
This was referenced Oct 9, 2024
This is not the code under test; only recompile when needed. Signed-off-by: Chris PeBenito <[email protected]>
pebenito
force-pushed
the
validate-appconfig-more
branch
from
5c7a8ef to
b6cd1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New validations:
Additionally add GitHub annotations to logging.