Skip to content

Commit

Permalink
improve error logs
Browse files Browse the repository at this point in the history
  • Loading branch information
franzmueller committed Jan 22, 2025
1 parent 16a52a1 commit 2912714
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
5 changes: 5 additions & 0 deletions pkg/api/budgets.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func BudgetEndpoints(router *httprouter.Router, _ configuration.Config, control
}
limitInt, err := strconv.Atoi(limit)
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusBadRequest)
return
}
Expand All @@ -49,12 +50,14 @@ func BudgetEndpoints(router *httprouter.Router, _ configuration.Config, control
}
offsetInt, err := strconv.Atoi(offset)
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusBadRequest)
return
}

budgets, err := control.GetBudgets(limitInt, offsetInt, []string{}, "", "")
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusInternalServerError)
return
}
Expand Down Expand Up @@ -83,8 +86,10 @@ func BudgetEndpoints(router *httprouter.Router, _ configuration.Config, control
err := control.DeleteBudget(request.URL.Query().Get("budget_identifier"), request.URL.Query().Get("user_id"), request.URL.Query().Get("role"))
if err != nil {
if errors.Is(err, models.ErrorNotFound) {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusNotFound)
} else {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusInternalServerError)
}
return
Expand Down
6 changes: 5 additions & 1 deletion pkg/api/flow-engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@
package api

import (
"log"
"net/http"

"github.com/SENERGY-Platform/budget/pkg/api/util"
"github.com/SENERGY-Platform/budget/pkg/configuration"
"github.com/SENERGY-Platform/budget/pkg/controller"
"github.com/julienschmidt/httprouter"
"net/http"
)

func init() {
Expand All @@ -32,10 +34,12 @@ func CheckFlowEngineEndpoints(router *httprouter.Router, c configuration.Config,
router.POST("/check/analytics/flow-engine", func(writer http.ResponseWriter, request *http.Request, params httprouter.Params) {
parsed, err := util.ParseRequest(request.Body, c.Debug)
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusBadRequest)
}
code, err := control.CheckFlowEngine(parsed)
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), code)
}
})
Expand Down
6 changes: 5 additions & 1 deletion pkg/api/import-deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@
package api

import (
"log"
"net/http"

"github.com/SENERGY-Platform/budget/pkg/api/util"
"github.com/SENERGY-Platform/budget/pkg/configuration"
"github.com/SENERGY-Platform/budget/pkg/controller"
"github.com/julienschmidt/httprouter"
"net/http"
)

func init() {
Expand All @@ -32,11 +34,13 @@ func CheckImportDeployEndpoints(router *httprouter.Router, c configuration.Confi
router.POST("/check/import/deploy", func(writer http.ResponseWriter, request *http.Request, params httprouter.Params) {
parsed, err := util.ParseRequest(request.Body, c.Debug)
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), http.StatusBadRequest)
}

code, err := control.CheckImportDeploy(parsed)
if err != nil {
log.Println("ERROR: " + err.Error())
http.Error(writer, err.Error(), code)
}
})
Expand Down

0 comments on commit 2912714

Please sign in to comment.