Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API versions from v58.0 to v59.0 #1397

Conversation

groundwired
Copy link
Contributor

Critical Changes

RollupDmlGuard API version updated to v58.0

Changes

No code changes - just version updates in two files that were missed

Issues Closed

#1396

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @groundwired to sign the Salesforce Inc. Contributor License Agreement.

@aheber
Copy link
Contributor

aheber commented Oct 17, 2023

This is great but it is actually time to bring everything up to API V59.0, would you be willing to change this to V59.0?

If you can cleanup the extra file and sign the CLA that should be everything we need to accept this! Really appreciate you bringing a problem and a solution.

@groundwired groundwired requested a review from a team as a code owner October 18, 2023 00:27
@groundwired
Copy link
Contributor Author

groundwired commented Oct 18, 2023

This is great but it is actually time to bring everything up to API V59.0, would you be willing to change this to V59.0?

If you can cleanup the extra file and sign the CLA that should be everything we need to accept this! Really appreciate you bringing a problem and a solution.

@aheber Should be all set!

@groundwired groundwired changed the title Updated API version to v58.0 for RollupDmlGuard class Updated API versions from v58.0 to v59.0 Oct 18, 2023
@aheber
Copy link
Contributor

aheber commented Oct 18, 2023

This looks great, thank you for expanding it! You even caught all the non-xml versions that most people miss.

I'll have to figure out what we need to do to get the automated tests to run so we can accept this. I think we might need to recreate the branch inside the team-scope but I'll get back to you on that.

@groundwired
Copy link
Contributor Author

This looks great, thank you for expanding it! You even caught all the non-xml versions that most people miss.

I'll have to figure out what we need to do to get the automated tests to run so we can accept this. I think we might need to recreate the branch inside the team-scope but I'll get back to you on that.

That seems wise! FWIW, I did run all Apex tests in the package in my scratch org. Everything passes.

@aheber
Copy link
Contributor

aheber commented Oct 30, 2023

@groundwired I think you should have received an invite to join the project. That should allow you to close this PR and your branch under your name. Push these changes to a branch directly on the project an open a new PR. That will allow the automation to run and validate your changes and get the needed passes so we can merge.

Sorry for the trouble but hopefully it isn't a lot of work.

@groundwired groundwired deleted the feature/DmlGuardVersionUpdate branch October 31, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants