-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement most CSFML 2.6.0 features #243
Conversation
6cecc08
to
6a891f0
Compare
6a891f0
to
6729e66
Compare
Rebased from master |
6729e66
to
8bfdda1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small var
changes
Is there some benefit to wrapping WindowBase that I'm missing? It's not extensible from C# as it's basically used as an interface in SFML. Also, I realize that |
WindowBase is not quite an interface from what I understand. It's supposed to be a very basic window so one can use OpenGL, Vulkan etc. on top of it without SFML intervening. |
What do you mean with "wrapping". The point of
I wouldn't change it on this PR, it's already mixing a lot of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for implementing this all! 🙂 |
This PR aims to implement most things from CSFML 2.6.0, along with some stuff that might be missing from CSFML 2.5.2.
Change list from 2.6.0:
sfFont_setSmooth
/sfFont_isSmooth
sfBlendMin
&sfBlendMax
sfFloatRect_getPosition
/sfIntRect_getPosition
&sfFloatRect_getSize
/sfIntRect_getSize
sfFont_getBoldKerning
sf::Vulkan
functions (partial)sfRenderTexture_isSrgb
/sfRenderWindow_isSrgb
sfImage_saveToMemory
withsfBuffer
sf::WindowBase
Other things which were done in this PR (probably missing from CSFML 2.5.2?):
drawVertexBufferRange
implementations from CSFMLTextureCoordinateType
implementationsfContext_isExtensionAvailable
andsfContext_getFunction
sfWindowBase_createVulkanSurface
Features which were not done due to issues:
sfVulkan_getGraphicsRequiredInstanceExtensions
- needs a CSFML release containing CSFML#229sfKeyboard_getDescription
- this function returns an owning C pointer (const char*
). I'm not sure how to handle the deallocation for it since there's no corresponding function to free the stringBy the looks of it, this PR might overlap / conflict with #236, #239, #240, and maybe #238.
This PR is a mess and I don't expect it to pass first inspection, so any feedback is welcome.