-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SHA-256 algorithm (RFC 8760) #676
Conversation
Thank you!
|
Hi, @orgads
Thanks for review! |
Thank you! I didn't test functionality yet, but compilation and tests pass. |
Verified it works, thank you! Please remove the flag. |
LGTM |
I've found only a small mostly cosmetic issue. Please address it and rebase on top of current master branch. |
3cdbc39
to
bcf8221
Compare
Hi @lemenkov . I've rebased branch and added unit test. |
Thank you! Maybe squash all the commits at this point? I would leave only the first one as a separate commit. |
018d0ec
to
538ba8f
Compare
No problem. I've squashed commits and rebased branch. |
Thanks! Please resolve the open discussion. |
Did you mean comment from github-advanced-security bot? |
I meant our discussion about CMakeLists. You already resolved it :) |
@Maratk1n your PR raises a minimum OpenSSL version up to 1.1.0 but still there is a mention of 0.9.8 version in the doc-files. See my notes above. |
538ba8f
to
1f0b4f9
Compare
Thank you @lemenkov . Fixed. |
@orgads looks good to me. What's your opinion? |
lgtm |
No description provided.