Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiments 1 and 2 #35

Merged
merged 21 commits into from
Jan 17, 2022
Merged

Experiments 1 and 2 #35

merged 21 commits into from
Jan 17, 2022

Conversation

Silvertrousers
Copy link
Contributor

Adding the section for experiments 1 and 2 as well as a definition for the stability. This is the first PR for experiments another will come.

@Silvertrousers Silvertrousers requested review from a team and jzzheng22 January 17, 2022 03:00
SaraFFdez
SaraFFdez reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@SaraFFdez SaraFFdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and typos fixed

Rhys-J
Rhys-J reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Rhys-J Rhys-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes in places

daryllimyt
daryllimyt requested changes Jan 17, 2022
View reviewed changes
jzzheng22
jzzheng22 previously requested changes Jan 17, 2022
View reviewed changes
@Silvertrousers
Copy link
Contributor Author

@daryllimyt @jzzheng22 Can you review my changes pls

@Rhys-J Rhys-J self-requested a review January 17, 2022 03:54
Rhys-J
Rhys-J approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Rhys-J Rhys-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good since all comments have been addressed

@Rhys-J Rhys-J dismissed jzzheng22’s stale review January 17, 2022 04:05

He said that I could, please merge

@Silvertrousers Silvertrousers merged commit f6bf91d into main Jan 17, 2022
@Silvertrousers Silvertrousers deleted the experiments branch January 17, 2022 04:06
@Silvertrousers Silvertrousers restored the experiments branch January 17, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaraFFdez SaraFFdez SaraFFdez left review comments

@daryllimyt daryllimyt daryllimyt approved these changes

@Rhys-J Rhys-J Rhys-J approved these changes

@jzzheng22 jzzheng22 jzzheng22 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Silvertrousers @daryllimyt @jzzheng22 @SaraFFdez @Rhys-J