Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use K8S Provider to manage AWS Auth ConfigMap #3

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Use K8S Provider to manage AWS Auth ConfigMap #3

merged 2 commits into from
Apr 15, 2022

Conversation

lawliet89
Copy link
Contributor

kubernetes_config_map_v1_data
See terraform-aws-modules/terraform-aws-eks#1999

@lawliet89 lawliet89 changed the title Use K8S Provider to manage AWS Auth ConfirMap Use K8S Provider to manage AWS Auth `ConfigMap Apr 14, 2022
@lawliet89 lawliet89 changed the title Use K8S Provider to manage AWS Auth `ConfigMap Use K8S Provider to manage AWS Auth ConfigMap Apr 14, 2022
provider "kubernetes" {
host = module.eks.cluster_endpoint
cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
token = data.aws_eks_cluster_auth.this.token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use exec instead of data.aws_eks_cluster_auth.this.token as mentioned in the comment ?
in terraform-aws-modules/terraform-aws-eks#1999 (comment)

Copy link
Contributor Author

@lawliet89 lawliet89 Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terraform cloud agents will not have aws cli installed.

This data source serves the same purpose anyway.

Copy link
Contributor

@niroz89 niroz89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one question added.

@lawliet89 lawliet89 merged commit d494d1e into main Apr 15, 2022
@lawliet89 lawliet89 deleted the aws-auth branch April 15, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants