Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search to TV demo #336

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add search to TV demo #336

merged 1 commit into from
Nov 28, 2023

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 24, 2023

Pull request

Description

This PR adds the search to the demo app for TV.

Changes made

  • Move the SearchViewModel to pillarbox-demo-shared to be able to reuse it on TV
  • Add a search icon in the top navigation to access the search
  • Make the existing media list component public so it can be reused in the search
    • Add new arguments to address the needs of the search: don't display a title, custom empty state, don't auto focus the first item
  • Create a search screen allowing the user to input a query, and select a BU

Screenshots

Description Screenshot
Access to the search Screenshot_20231124_110636
Empty screen Screenshot_20231124_110438
Search results Screenshot_20231124_110628
No results Screenshot_20231124_110512

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 24, 2023 that may be closed by this pull request
1 task
@StaehliJ
Copy link
Contributor

Some improvements could be to use the voice search like it was done with Leanback. Maybe for a future feature.

@StaehliJ StaehliJ merged commit 7b9169e into main Nov 28, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 274-add-search-in-demo-tv branch November 28, 2023 08:14
@MGaetan89
Copy link
Member Author

Some improvements could be to use the voice search like it was done with Leanback. Maybe for a future feature.

I've created #347 to address that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search in Demo TV
2 participants