Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a PillarboxCastPlayer and update the demo #875

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Add a PillarboxCastPlayer and update the demo #875

merged 1 commit into from
Jan 23, 2025

Conversation

MGaetan89
Copy link
Member

Pull request

Description

Create a PillarboxCastPlayer and update the pillarbox-demo-cast project.

Changes made

  • Self-explanatory.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 requested a review from StaehliJ January 23, 2025 13:25
@MGaetan89 MGaetan89 linked an issue Jan 23, 2025 that may be closed by this pull request
Create a PillarboxCastPlayer #870
Closed
@StaehliJ StaehliJ enabled auto-merge January 23, 2025 13:26
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 51.95% -0.11% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-cast 0% -21.12% 🟢
Files
Module File Coverage
:pillarbox-cast PillarboxCastPlayer.kt 0% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 52546bd Jan 23, 2025
9 checks passed
@MGaetan89 MGaetan89 deleted the 870-create-a-pillarboxcastplayer branch January 23, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a PillarboxCastPlayer
2 participants
@MGaetan89 @StaehliJ