Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested layers to avoid animation issues #1010

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Sep 13, 2024

Description

This PR fixes video view lagging animation issues we recently noticed when updating our Podcastator sandbox app.

Before After
before.mp4
after.mp4

Changes made

  • Use video layer as layer class of VideoLayerView.
  • Update PiP implementation to store and restore a VideoLayerView instead of a layer.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Sep 13, 2024 that may be closed by this pull request
5 tasks
@defagos defagos self-assigned this Sep 13, 2024
@defagos defagos enabled auto-merge September 13, 2024 16:47
@defagos defagos added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@defagos defagos added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@defagos defagos added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@defagos defagos added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@defagos defagos force-pushed the 1006-videoview-undesired-implicit-animations branch from ef99902 to be8e8d5 Compare September 16, 2024 07:13
@defagos defagos enabled auto-merge September 16, 2024 07:22
@waliid waliid self-requested a review September 16, 2024 07:22
@defagos defagos added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 44280b7 Sep 16, 2024
6 checks passed
@defagos defagos deleted the 1006-videoview-undesired-implicit-animations branch September 16, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

VideoView undesired implicit animations
2 participants