Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system video view overlay issues #1122

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Conversation

defagos
Copy link
Member

@defagos defagos commented Jan 23, 2025

Description

This PR fixes two issues introduced in #430:

  • The overlay was opaque, always hiding the content behind it.
  • The app was crashing when transitioning from an inline system video view to its full screen counterpart (due to parent / child relationship inconsistency).

Changes made

  • Remove parent / child relationship to avoid the crash.
  • Make the overlay hosting controller view background trasnparent.
  • Improve property naming.
  • Make system video view coordinator available on all platforms (even if only doing meaningful work for tvOS at the moment).

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos added the bug Something isn't working label Jan 23, 2025
@defagos defagos enabled auto-merge January 23, 2025 13:04
@defagos defagos added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@defagos defagos added this pull request to the merge queue Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@defagos defagos added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 3ebfc89 Jan 23, 2025
7 checks passed
@defagos defagos deleted the system-video-view-overlay-fixes branch January 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants