Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom server initializer #1133

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Remove custom server initializer #1133

merged 1 commit into from
Feb 5, 2025

Conversation

defagos
Copy link
Member

@defagos defagos commented Feb 5, 2025

Description

This PR removes the custom server initializer, fixing a regression introduced in version 7.0.0 which intended to keep it for a while (but as a result would not play any URN in debug builds).

Note that we could have kept the API somehow private but we still agreed that alternative server configurations currently offered by the demo (SAM, geoblocking) are not really useful. If really needed we can test such configurations in a debug build, tweaking URLs and request headers before.

Changes made

  • Remove custom Server initializer.
  • Remove all non-standard server configurations from the demo.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos enabled auto-merge February 5, 2025 09:25
@defagos defagos added bug Something isn't working enhancement New feature or request labels Feb 5, 2025
@defagos defagos added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit e42864b Feb 5, 2025
7 checks passed
@defagos defagos deleted the custom-server-removal branch February 5, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants