-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics tracker to most recent specifications #967
Merged
defagos
merged 46 commits into
main
from
966-update-metric-tracker-to-most-recent-specifications
Aug 11, 2024
Merged
Update metrics tracker to most recent specifications #967
defagos
merged 46 commits into
main
from
966-update-metric-tracker-to-most-recent-specifications
Aug 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower-case UUIDs are more widespread, see ITU-T X.667
12 tasks
4 tasks
waliid
approved these changes
Aug 10, 2024
Co-authored-by: Walid Kayhal <[email protected]>
Co-authored-by: Walid Kayhal <[email protected]>
waliid
approved these changes
Aug 11, 2024
Thank you very much for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our metrics tracker implementation so that it conforms to the latest version of our specifications. After having identified a few issues during the implementation I also realized that having no UTs for our metrics tracker implementation was risky. I therefore introduced the necessary testing infrastructure so that we can ensure our implementation stays reliable over time.
Changes made
stop
event being sent when nostart
event has been sent.PillarboxMonitoring
scheme.Checklist