Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics tracker to most recent specifications #977

Merged
merged 17 commits into from
Aug 16, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Aug 15, 2024

Description

This PR applies changes recently discussed. Specifications themselves should now be stable or almost stable. This should therefore be one of the latest associated PRs.

Changes made

  • See related issue for changes related to the specifications.
  • Improved implementation by building common payload at a single location.
  • Always use event creation date as timestamp.
  • Implement proper session management.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Aug 15, 2024 that may be closed by this pull request
4 tasks
@defagos defagos enabled auto-merge August 15, 2024 13:16
@defagos defagos disabled auto-merge August 15, 2024 13:22
@defagos defagos marked this pull request as draft August 15, 2024 13:22
@defagos defagos force-pushed the 975-update-to-last-version-of-qos-specs branch from 2e69069 to d4e0046 Compare August 15, 2024 19:38
@defagos defagos marked this pull request as ready for review August 15, 2024 19:46
@defagos defagos enabled auto-merge August 15, 2024 20:08
@defagos defagos force-pushed the 975-update-to-last-version-of-qos-specs branch from dc1ba0b to 2f67217 Compare August 16, 2024 07:36
Sources/Monitoring/MetricsTracker.swift Outdated Show resolved Hide resolved
Co-authored-by: Walid Kayhal <[email protected]>
@defagos
Copy link
Member Author

defagos commented Aug 16, 2024

@waliid Thanks for the review!

@defagos defagos added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 8b67f3f Aug 16, 2024
6 checks passed
@defagos defagos deleted the 975-update-to-last-version-of-qos-specs branch August 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update to latest version of QoS specs
2 participants