Skip to content

Commit

Permalink
chore(demo): player captions settings focus
Browse files Browse the repository at this point in the history
When navigating with the keyboard, the focus is not correctly set on the `select`
html elements of the captions settings.

This is caused by two css rules in two different files:

1. **player.scss**, `select` set to `all:unset`
2. **index.scss**, `select` set to `outline:none`

Set `outline` to `solid` during `focus-within`. This solution was preferred
while waiting for the end of the transition to Lit.
  • Loading branch information
amtins committed Dec 14, 2023
1 parent c1e8750 commit 494bf47
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions demo/scss/player.scss
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,10 @@
background: #333;
border: none;
appearance: auto;

&:focus-within {
outline: solid;
}
}

.vjs-modal-dialog.vjs-text-track-settings {
Expand Down

0 comments on commit 494bf47

Please sign in to comment.