chore(demo): update player look and feel #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success145 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 6b72664 |
amtins
force-pushed
the
chore/110-update-demo-player-look-and-feel
branch
3 times, most recently
from
41c479c to
8099c67
Compare
jboix
reviewed
Dec 4, 2023
amtins
force-pushed
the
chore/110-update-demo-player-look-and-feel
branch
from
8099c67 to
8ac1e5c
Compare
jboix
approved these changes
Dec 4, 2023
Resolves #110 and by creating a style sheet to modify the player's appearance. - **player.js** - add import file extension - active pillarbox reponsive mode - **player.scss** - overrides side effects caused by global styles - `pbw-demo` define player layout size - modify `vjs-title-bar` style - move `vjs-text-track-display` up so that it aligns with the control bar - modify `vjs-big-play-button` style - modify `vjs-loading-spinner` style and animation - modify `vjs-control-bar` style - display `vjs-current-time` and `vjs-duration` unless it's a live stream - hide `vjs-remaining-time` - modify `vjs-progress-control` style - modify `vjs-volume-tooltip` style - modify `vjs-menu` style - modify `vjs-error-display` style - modify `vjs-text-track-settings` style - imports **player.scss** into **index.scss**
amtins
force-pushed
the
chore/110-update-demo-player-look-and-feel
branch
from
8ac1e5c to
6b72664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #110 and by creating a style sheet to modify the player's appearance.
Changes made
pbw-demodefine player layout sizevjs-title-barstylevjs-text-track-displayup so that it aligns with the control barvjs-big-play-buttonstylevjs-loading-spinnerstyle and animationvjs-control-barstylevjs-current-timeandvjs-durationunless it's a live streamvjs-remaining-timevjs-progress-controlstylevjs-volume-tooltipstylevjs-menustylevjs-error-displaystylevjs-text-track-settingsstyle